Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to php 8.2 as the default #2690

Merged
merged 18 commits into from
Dec 2, 2023
Merged

Switch to php 8.2 as the default #2690

merged 18 commits into from
Dec 2, 2023

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Nov 28, 2023 •
edited
Loading

Switch to 8.2 as the default PHP, 8.0 is no longer supported, 8.1 is security fixes only, and 8.3 is brand new, so 8.2 it is!

If people need 8.0 or other versions they can use the core extensions

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@tomjn
switch to php 8.2 as the default
22ce286 
Switch to 8.2 as the default PHP, 8.0 is no longer supported, 8.1 is security fixes only, and 8.3 is brand new, so 8.2 it is!

If people need 8.0 or other versions they can use the core extensions
@update-docs Update Docs
Copy link

update-docs bot commented Nov 28, 2023 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn requested a review from a team November 28, 2023 10:41
@tomjn tomjn added this to the 3.13 milestone Nov 28, 2023
@tomjn tomjn marked this pull request as ready for review November 28, 2023 10:41
@tomjn
Copy link
Member Author

tomjn commented Nov 28, 2023

Also noting that a number of hosts are skipping 8.1 as an option, e.g. WP Engine, and VIP is on 8.2

Mte90
Mte90 previously approved these changes Nov 28, 2023
View reviewed changes
@tomjn
Copy link
Member Author

tomjn commented Nov 28, 2023

Checks failed, missed an 8.0 in the site provisioner

@Mte90
Copy link
Member

Mte90 commented Nov 28, 2023

There is still something using php 8.0

@tomjn tomjn requested a review from Mte90 November 28, 2023 16:06
@tomjn
Copy link
Member Author

tomjn commented Nov 28, 2023

Ended up needing some fixes in the site template to avoid a sed issue in docker

@tomjn tomjn merged commit 1d47578 into develop Dec 2, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mte90 Mte90 Awaiting requested review from Mte90

Assignees
No one assigned
Labels
provisioner:core
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjn @Mte90